Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't put entire actor registry in debug string since it's too long #3395

Merged
merged 4 commits into from
Nov 28, 2018
Merged

Don't put entire actor registry in debug string since it's too long #3395

merged 4 commits into from
Nov 28, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Nov 25, 2018

No description provided.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9577/
Test FAILed.

@ericl
Copy link
Contributor Author

ericl commented Nov 27, 2018

Ping

@robertnishihara
Copy link
Collaborator

@ericl Compilation error

In file included from /Users/travis/build/ray-project/ray/src/ray/raylet/actor_registration.cc:1:
/Users/travis/build/ray-project/ray/src/ray/raylet/actor_registration.h:107:8: error: private field 'alive_' is not used [-Werror,-Wunused-private-field]
  bool alive_;
       ^
1 error generated.
make[2]: *** [src/ray/CMakeFiles/ray_objlib.dir/raylet/actor_registration.cc.o] Error 1
make[1]: *** [src/ray/CMakeFiles/ray_objlib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
3 warnings generated.

@robertnishihara robertnishihara merged commit c2108ca into ray-project:master Nov 28, 2018
@robertnishihara robertnishihara deleted the cleanup-ar branch November 28, 2018 00:48
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9634/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees

@robertnishihara robertnishihara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @robertnishihara